Skip to content

Doc: Make all versions sidebars the same for consistency.#10288

Merged
JulienPalard merged 2 commits into
python:masterfrom
JulienPalard:doc-sidebar-consistency
Nov 7, 2018
Merged

Doc: Make all versions sidebars the same for consistency.#10288
JulienPalard merged 2 commits into
python:masterfrom
JulienPalard:doc-sidebar-consistency

Conversation

@JulienPalard

Copy link
Copy Markdown
Member

If merged, it will have to be backported (probably manually as the diff is different on every versions), to make this consistent over all versions (2.7, 3.5, 3.6, and 3.7).

@matrixise

Copy link
Copy Markdown
Member

@JulienPalard LGTM for me, you can merge it.

@JulienPalard JulienPalard merged commit 556d50d into python:master Nov 7, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @JulienPalard, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 556d50d03dd1d457c01ab552c8bc81f3431a0746 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
…0288)

(cherry picked from commit 556d50d)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot

Copy link
Copy Markdown

GH-10404 is a backport of this pull request to the 3.6 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @JulienPalard, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 556d50d03dd1d457c01ab552c8bc81f3431a0746 2.7

JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Nov 8, 2018
…onGH-10288).

(cherry picked from commit 556d50d)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot

Copy link
Copy Markdown

GH-10409 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-10410 is a backport of this pull request to the 2.7 branch.

JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Nov 8, 2018
…onGH-10288).

(cherry picked from commit 556d50d)

Co-authored-by: Julien Palard <julien@palard.fr>
miss-islington added a commit that referenced this pull request Nov 9, 2018
…0288) (GH-10404)

(cherry picked from commit 556d50d)


Co-authored-by: Julien Palard <julien@palard.fr>
@JulienPalard JulienPalard deleted the doc-sidebar-consistency branch June 16, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants